Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defined endpoints for file compression and added missing imports in sender.py #792

Merged
merged 4 commits into from
Jul 29, 2019
Merged

Defined endpoints for file compression and added missing imports in sender.py #792

merged 4 commits into from
Jul 29, 2019

Conversation

kmehant
Copy link
Collaborator

@kmehant kmehant commented Jun 2, 2019

Description

  • Defined endpoints for file compression
  • Added missing imports in sender.py

Related Issue

Fixes #791

Motivation and Context

This change is required for existing file compression and file download feature to work.

How Has This Been Tested?

This has been tested locally using Docker containers

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kmehant
Copy link
Collaborator Author

kmehant commented Jun 2, 2019

@vivonk @agentmilindu Please review this PR

@kmehant kmehant assigned kmehant and unassigned kmehant Jun 2, 2019
@kmehant kmehant added bug GSoC-2019 Tasks for GSoC-2019 labels Jun 2, 2019
@kmehant kmehant self-assigned this Jun 2, 2019
@kmehant kmehant requested a review from JaDogg June 2, 2019 06:08
@kmehant kmehant mentioned this pull request Jun 2, 2019
Merged
8 tasks
vivonk
vivonk reviewed Jun 3, 2019
View reviewed changes
Copy link
Collaborator

@vivonk vivonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

components/core/routes/Download.py Outdated Show resolved Hide resolved
vivonk
vivonk previously approved these changes Jun 4, 2019
View reviewed changes
@vivonk vivonk self-requested a review June 5, 2019 19:18
vivonk
vivonk approved these changes Jun 18, 2019
View reviewed changes
Copy link
Collaborator

@vivonk vivonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @agentmilindu please approve this one. Necessary for Bassa to function well

@kmehant kmehant added the API issues related to Bassa API server label Jun 19, 2019
@kmehant
Copy link
Collaborator Author

kmehant commented Jul 4, 2019

@vivonk @agentmilindu Shall we merge this to develop?

@vivonk vivonk merged commit 42d4bc6 into scorelab:develop Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivonk vivonk vivonk approved these changes

@JaDogg JaDogg JaDogg approved these changes

@agentmilindu agentmilindu Awaiting requested review from agentmilindu

@malithsen malithsen Awaiting requested review from malithsen

@charithccmc charithccmc Awaiting requested review from charithccmc

Assignees

@kmehant kmehant

Labels
API issues related to Bassa API server bug GSoC-2019 Tasks for GSoC-2019
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmehant @JaDogg @vivonk